Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17822 )
Change subject: [client] Fix KuduSchema operator != bug ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc File src/kudu/client/client-unittest.cc: http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc@304 PS2, Line 304: ASSERT_TRUE nit: could use ASSERT_EQ() here? http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc@325 PS2, Line 325: s1 typo: s3 ? http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/schema.cc@872 PS2, Line 872: return !(*this == rhs); Nice catch! -- To view, visit http://gerrit.cloudera.org:8080/17822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209 Gerrit-Change-Number: 17822 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 31 Aug 2021 16:39:33 +0000 Gerrit-HasComments: Yes
