Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17773 )
Change subject: KUDU-1260: Fix prefetching bug on Java scanner ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17773/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17773/9//COMMIT_MSG@17 PS9, Line 17: The fix is simple: : just use a small queue to cache the prefetching result Maybe, getting rid of blocking queue and using compare-and-exchange approach could be a better choice here? It could help to avoid the issue of sending multiple scan requests concurrently. In essence, if it's necessary to schedule a pre-fetch request, the code should add a new deferred if there isn't a deferred doing pre-fetching already, otherwise, it should chain a new deferred to the already existing one? Could this work? -- To view, visit http://gerrit.cloudera.org:8080/17773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I853a041d86c75ec196d7d4ff45af4673c5c5f5cd Gerrit-Change-Number: 17773 Gerrit-PatchSet: 9 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Sep 2021 07:06:48 +0000 Gerrit-HasComments: Yes
