Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17836 )

Change subject: KUDU-2671 test for unbounded range with custom empty hash schema
......................................................................


Patch Set 1:

> Can you also add a test scenario within partition-test.cc ensuring
 > the end partition key is unbounded for the last range? The current
 > test case for unbounded ranges within partition-test.cc uses a
 > custom hash schema for the last range. Maybe you could update the
 > existing test scenario by clearing the necessary parameters after
 > the first set of partitions.

I verified that the code in question in partition.cc is visited when running 
the newly added test case.

Of course, I can add a new test case into partition-test.cc as well.


--
To view, visit http://gerrit.cloudera.org:8080/17836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2198714a8025ae4b132afc4cd4700de18df226cb
Gerrit-Change-Number: 17836
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Comment-Date: Thu, 09 Sep 2021 07:01:03 +0000
Gerrit-HasComments: No

Reply via email to