Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17841 )
Change subject: KUDU-2671: Pruning compatible with unbounded ranges. ...................................................................... Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/17841/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17841/1//COMMIT_MSG@9 PS1, Line 9: unbounded nit: absent ? http://gerrit.cloudera.org:8080/#/c/17841/1//COMMIT_MSG@11 PS1, Line 11: unbounded nit: absent ? http://gerrit.cloudera.org:8080/#/c/17841/1/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17841/1/src/kudu/common/partition_pruner.cc@459 PS1, Line 459: if (range.upper.empty() || scan_range_lower_bound < range.upper) { Good catch! It seems we might benefit from introducing a special class wrapper for a range's boundary and implement corresponding comparison operators to avoid mistakes like this in the future. -- To view, visit http://gerrit.cloudera.org:8080/17841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic11bc7ceac7f3863c9d7e3440813f1faa3860b8e Gerrit-Change-Number: 17841 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 11 Sep 2021 01:37:47 +0000 Gerrit-HasComments: Yes
