Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17843 )
Change subject: [util] add clarifying comments on DnsResolver ...................................................................... [util] add clarifying comments on DnsResolver As it turned out, the code under #ifndef NDEBUG ... #endif section looks a bit surprising when reading the code in dns_resolver.cc without first reading the comment for the HostRecordCache typedef in dns_resolver.h. This patch adds comments to bring more clarity on the motivation behind that code. This changelist doesn't contain any functional modifications. Change-Id: I6a7fafbd8897844fc22db5cc431bae039eb85797 Reviewed-on: http://gerrit.cloudera.org:8080/17843 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/util/net/dns_resolver.cc 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Andrew Wong: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/17843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6a7fafbd8897844fc22db5cc431bae039eb85797 Gerrit-Change-Number: 17843 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
