Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17854 )
Change subject: [common] small re-factoring on PartitionPruner ...................................................................... [common] small re-factoring on PartitionPruner This changelist simplifies the signature of the PartitionPruner::ConstructPartitionKeyRanges() method: the in-out parameter is removed and turned into the return value. I also moved RangeBoundsAndPartitionKeyRanges, RangeBounds, and PartitionKeyRange structures into the private section of the PartitionPruner class and removed default constructor declarations for them. There is no point of declaring default constructors for structures: the compiler creates them automatically. This patch doesn't contain any functional changes. Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e Reviewed-on: http://gerrit.cloudera.org:8080/17854 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/common/partition_pruner.cc M src/kudu/common/partition_pruner.h 2 files changed, 37 insertions(+), 48 deletions(-) Approvals: Alexey Serbin: Verified Mahesh Reddy: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e Gerrit-Change-Number: 17854 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
