Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17856 )
Change subject: [master] fix logic error in TableInfo::UpdateMetrics() ...................................................................... Patch Set 1: > > Patch Set 1: > > > > ts_tablet_manager.h says this. Could you update the comment there > as well? > > // Map from tablet ID to tablet > > TabletMap tablet_map_; > > I'm sorry I looked at the wrong file. It should catalog_manager.h > even there the comment says tablet-id. > > // Tablet maps: tablet-id -> TabletInfo > TabletInfoMap tablet_map_; I don't think that's not the container used in this context. Here we are talking about TableInfo::tablet_map_, see catalog_manager.h lines 390-395: // Sorted index of tablet start partition-keys to TabletInfo. // // Every TabletInfo has a strong backpointer to its TableInfo, so these // pointers must be raw. typedef std::map<PartitionKey, TabletInfo*> RawTabletInfoMap; RawTabletInfoMap tablet_map_; -- To view, visit http://gerrit.cloudera.org:8080/17856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d22f4b1fedeb341d261c3ac2e61a29feb3cb2d Gerrit-Change-Number: 17856 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hel...@apache.org> Gerrit-Comment-Date: Wed, 22 Sep 2021 03:20:50 +0000 Gerrit-HasComments: No
