Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17892 )
Change subject: [rpc] allow reuse of outbound request buffers when retrying ...................................................................... Patch Set 2: -Code-Review (2 comments) http://gerrit.cloudera.org:8080/#/c/17892/2/src/kudu/rpc/rpc_controller.cc File src/kudu/rpc/rpc_controller.cc: http://gerrit.cloudera.org:8080/#/c/17892/2/src/kudu/rpc/rpc_controller.cc@172 PS2, Line 172: call_->FreeSidecars(); What about zeroing outbound_sidecars_total_bytes_: should it be done here as well? http://gerrit.cloudera.org:8080/#/c/17892/2/src/kudu/rpc/rpc_controller.cc@176 PS2, Line 176: return std::move(outbound_sidecars_); ditto -- To view, visit http://gerrit.cloudera.org:8080/17892 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I118f3559c4647bdd996617443bd371a041711295 Gerrit-Change-Number: 17892 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 Oct 2021 19:43:58 +0000 Gerrit-HasComments: Yes
