Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17890 )
Change subject: KUDU-2671 introduce PartitionKey ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/catalog_manager-test.cc File src/kudu/master/catalog_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/catalog_manager-test.cc@101 PS4, Line 101: TEST(TableInfoTest, GetTableLocationsLegacyCustomHashSchemas) { Would it make sense to add a test with multiple ranges and have the start and end partition keys be from different ranges? http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/catalog_manager.cc@6394 PS4, Line 6394: , nit: space after comma http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/17890/4/src/kudu/master/master.proto@654 PS4, Line 654: encoraged encouraged. -- To view, visit http://gerrit.cloudera.org:8080/17890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00255ec404beeb999117f5265de0d5d8deaf0d68 Gerrit-Change-Number: 17890 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 04 Oct 2021 22:58:26 +0000 Gerrit-HasComments: Yes
