Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17902 )
Change subject: [master] update on max_returned_locations semantics ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17902/1/src/kudu/master/catalog_manager-test.cc File src/kudu/master/catalog_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17902/1/src/kudu/master/catalog_manager-test.cc@222 PS1, Line 222: req.clear_max_returned_locations(); // the default is 10 in protobuf I'm curious, are we expecting to actually clear this value for our clients? Especially for huge ever-growing fact tables, this seems like it could yield huge responses -- To view, visit http://gerrit.cloudera.org:8080/17902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebc2b2295576c0b1b637fdeb95d4f9ff7b4d51c7 Gerrit-Change-Number: 17902 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Oct 2021 08:24:58 +0000 Gerrit-HasComments: Yes
