Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )
Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error ...................................................................... Patch Set 6: Verified+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc File src/kudu/integration-tests/dns_alias-itest.cc: http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@384 PS5, Line 384: > IIRC, catalog manager doesn't assign tablet replicas to a tablet server it Added a comment. The default is 60 seconds to be considered unresponsive. Also looped this 500 times and it passed 100%. http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@421 PS5, Line 421: auto tserver_proxy = cluster_->tserver_proxy(cluster_->num_tabl > nit: does it make sense to add check for resp.has_error() as well just for Done -- To view, visit http://gerrit.cloudera.org:8080/17909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef Gerrit-Change-Number: 17909 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 08 Oct 2021 21:40:18 +0000 Gerrit-HasComments: Yes
