Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17969 )

Change subject: [rpc] re-add methods_by_name()
......................................................................


Patch Set 1: Code-Review+1

Ah, good catch!

Thank you for adding a new test.

It seems IWYU isn't happy yet:

>>> Fixing #includes in 
>>> '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/rpc/rpc-test.cc'
@@ -48,6 +48,7 @@
 #include "kudu/rpc/outbound_call.h"
 #include "kudu/rpc/proxy.h"
 #include "kudu/rpc/reactor.h"
+#include "kudu/rpc/result_tracker.h"
 #include "kudu/rpc/rpc-test-base.h"
 #include "kudu/rpc/rpc_controller.h"
 #include "kudu/rpc/rpc_header.pb.h"


--
To view, visit http://gerrit.cloudera.org:8080/17969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbccdbbd119ebd53544d951e45b8bb4d34abae7
Gerrit-Change-Number: 17969
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Oct 2021 04:47:10 +0000
Gerrit-HasComments: No

Reply via email to