Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17984 )
Change subject: KUDU-3332 [tools] Fix too large next_column_id after unsafe_rebuilding master ...................................................................... Patch Set 2: (1 comment) Nice catch! Thanks for the patch! http://gerrit.cloudera.org:8080/#/c/17984/2/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/17984/2/src/kudu/tools/master_rebuilder.cc@213 PS2, Line 213: Status MasterRebuilder::CheckTableConsistency( In case there's a mismatch across replicas from before failing, should we bump the next column ID here too? -- To view, visit http://gerrit.cloudera.org:8080/17984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ccacc2e028a7c278a912bb68620aefec44026b9 Gerrit-Change-Number: 17984 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 29 Oct 2021 00:41:15 +0000 Gerrit-HasComments: Yes
