Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17947 )

Change subject: KUDU-1959 - Implement startup progress metrics related to 
containers and tablets
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

LGTM, barring one nit, assuming tests will come later (or at least that you've 
manually verified these).

http://gerrit.cloudera.org:8080/#/c/17947/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/17947/1/src/kudu/fs/log_block_manager.cc@163
PS1, Line 163: s"
It's probably worth mentioning that this is value is only for containers that 
exist when the LBM is first starting up.



--
To view, visit http://gerrit.cloudera.org:8080/17947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1aa85b0585214475a6bdb8c0e5d7343c5bc3c9
Gerrit-Change-Number: 17947
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Oct 2021 04:13:46 +0000
Gerrit-HasComments: Yes

Reply via email to