Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17903 )
Change subject: KUDU-1959 - Implement aggregate startup progress metrics ...................................................................... Patch Set 7: Code-Review+1 (1 comment) LGTM, though IWYU isn't happy yet http://gerrit.cloudera.org:8080/#/c/17903/7/src/kudu/server/startup_path_handler.cc File src/kudu/server/startup_path_handler.cc: http://gerrit.cloudera.org:8080/#/c/17903/7/src/kudu/server/startup_path_handler.cc@38 PS7, Line 38: kInfo > We need this to be in WARN level if any of the third party tools are filter Seems reasonable, given we might expect to use this to alert that the server isn't fully bootstrapped. -- To view, visit http://gerrit.cloudera.org:8080/17903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a508c3baf0a0d77baf75f36f7bb305a6ad821e1 Gerrit-Change-Number: 17903 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 02 Nov 2021 06:36:05 +0000 Gerrit-HasComments: Yes
