Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17993 )
Change subject: [txns] fix UB in TxnSystemClient when adding max timeout to now ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17993/1/src/kudu/transactions/txn_system_client.h File src/kudu/transactions/txn_system_client.h: http://gerrit.cloudera.org:8080/#/c/17993/1/src/kudu/transactions/txn_system_client.h@178 PS1, Line 178: MonoTime deadline, > Standardized to pass-by-value since it's a bit more flexible (allows functi Thanks! MonoTime is essentially 64-bit number in this regard, so passing by value makes sense. -- To view, visit http://gerrit.cloudera.org:8080/17993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e5d4d06e8c0801c7f6b2399f7622e6f039f988e Gerrit-Change-Number: 17993 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 03 Nov 2021 18:20:34 +0000 Gerrit-HasComments: Yes
