Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17989 )
Change subject: KUDU-1959 - Implement tests for the startup web page for Kudu Master ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17989/4/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17989/4/src/kudu/master/master.cc@265 PS4, Line 265: startup_path_handler_->initialize_master_catalog_progress()->Start(); Is it possible to move both Start() and Stop() for this timer into Master::InitCatalogManagerTask()? Call Start() in the very begin of the method, and call Stop() after calling Set() on the 'catalog_manager_init_status_' promise? -- To view, visit http://gerrit.cloudera.org:8080/17989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823a59df215cfeb579f1593a63ef6133de37271c Gerrit-Change-Number: 17989 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 04 Nov 2021 01:53:17 +0000 Gerrit-HasComments: Yes
