[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc@307 PS1, Line 307: } else if (symm_diff.size() > 1) { > +1 Done http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc@309 PS1, Line 309: difference is higher than 1. > nit: maybe, replace with Ack http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc@317 PS1, Line 317: ( > nit: why to add parentheses? Would it be OK to output the extra address ri No, it's not needed, I guess I just got used to adding parentheses in the previous messages :) http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/mini-cluster/external_mini_cluster.cc@1062 PS1, Line 1062: RemoveMaster > Could you update comment in the header, if needed. Done http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/mini-cluster/external_mini_cluster.cc@1085 PS1, Line 1085: (*master_it)->mutable_flags()->end() > Nit: Can flags->end() not be used here? Done -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 04 Nov 2021 15:24:05 +0000 Gerrit-HasComments: Yes
