Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17989 )
Change subject: KUDU-1959 - Add test for /startup page for the Master ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/17989/4/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/17989/4/src/kudu/master/master-test.cc@405 PS4, Line 405: : ASSERT_OK(mini_master_->Restart()); : ASSERT_OK(mini_master_->WaitForCatalogManagerInit()); : run > Whatever works best to join the thread in case of assertion triggers. Curr Yea, my concern was about running assertions in a different thread after an assertion fails on the main thread. It shouldn't be a problem though. http://gerrit.cloudera.org:8080/#/c/17989/8/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17989/8/src/kudu/master/master.cc@300 PS8, Line 300: ; nit: double semi-colon -- To view, visit http://gerrit.cloudera.org:8080/17989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823a59df215cfeb579f1593a63ef6133de37271c Gerrit-Change-Number: 17989 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Nov 2021 20:58:02 +0000 Gerrit-HasComments: Yes
