zcho...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17555 )
Change subject: [rest] add rest implementation ...................................................................... Patch Set 43: (7 comments) http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/controller.cc File src/kudu/rest/controller.cc: http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/controller.cc@129 PS43, Line 129: Table name has been changed" Could we include the old and new name for the table in this message? It probably would help in tracking operations. http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc File src/kudu/rest/rest_server.cc: http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@62 PS43, Line 62: nit: extra spaces http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@63 PS43, Line 63: nit: extra spaces http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@81 PS43, Line 81: nit: extra spaces http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@85 PS43, Line 85: nit: extra spaces http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@86 PS43, Line 86: nit: extra spaces http://gerrit.cloudera.org:8080/#/c/17555/43/src/kudu/rest/rest_server.cc@115 PS43, Line 115: = nit: spaces around the = are missing -- To view, visit http://gerrit.cloudera.org:8080/17555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ca3121fd7e95a1267853be45cb5f5855298c763 Gerrit-Change-Number: 17555 Gerrit-PatchSet: 43 Gerrit-Owner: Khazar Mammadli <mammadli.kha...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <zcho...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 17 Nov 2021 18:59:33 +0000 Gerrit-HasComments: Yes
