Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17851 )
Change subject: [tool] CLI to add a column ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/17851/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17851/4//COMMIT_MSG@9 PS4, Line 9: kudu tool not support adding a column, support it This body doesn't really add any extra information that the subject doesn't already tell. http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/kudu-tool-test.cc@4725 PS4, Line 4725: KuduSchemaBuilder schema_builder_2; nit: remove the underscore before "2". Also, how about putting both this and the above schema building in separate blocks? That way the name could be reused. http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/kudu-tool-test.cc@4736 PS4, Line 4736: KuduSchema schema_2; nit: can you use a more descriptive name, such as reference_schema? http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/kudu-tool-test.cc@4747 PS4, Line 4747: ASSERT_TRUE(table->schema().Column(2) == schema_2.Column(1)); nit: ASSERT_EQ? http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17851/4/src/kudu/tools/tool_action_table.cc@992 PS4, Line 992: value Who owns this memory? Is this leaked? -- To view, visit http://gerrit.cloudera.org:8080/17851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93e6c2af07e9fa5aa909b4a09b79b7c54401d4e3 Gerrit-Change-Number: 17851 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 22 Nov 2021 19:02:43 +0000 Gerrit-HasComments: Yes
