Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18045 )
Change subject: KUDU-2671 number of per-range hash dimensions should be fixed for now ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/18045/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18045/4//COMMIT_MSG@27 PS4, Line 27: (NOTE: the number of hash buckets must be : equal or greater than two) Thanks for clarifying this here! http://gerrit.cloudera.org:8080/#/c/18045/4//COMMIT_MSG@48 PS4, Line 48: I think : of starting using strings views (or Slice) for the range_key() and the : hash_key() methods in a follow-up changelist, regardless of how the : serialized partition key is represented under the hood in PartitionKey. : Yeah this is an interesting thought; I guess I'd focus decision-making on whatever makes life easy for partition pruning. http://gerrit.cloudera.org:8080/#/c/18045/4/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/18045/4/src/kudu/client/flex_partitioning_client-test.cc@759 PS4, Line 759: { nit: unnecessary scope? -- To view, visit http://gerrit.cloudera.org:8080/18045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic884fa556462b85c64d77385a521d9077d33c7c1 Gerrit-Change-Number: 18045 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Nov 2021 23:11:57 +0000 Gerrit-HasComments: Yes
