Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [encryption] KUDU-3316 Add encrypted file keys to files ...................................................................... Patch Set 3: (3 comments) just one high-level question for now http://gerrit.cloudera.org:8080/#/c/18025/3/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/18025/3/src/kudu/util/env.h@194 PS3, Line 194: exclude_encryption_header Looking at proliferation of extra parameters for the methods like this, I started thinking: maybe deriving special EncryptedEnv from Env and using it to access encrypted files could be an alternative here? Did you explore this alternative approach? http://gerrit.cloudera.org:8080/#/c/18025/3/src/kudu/util/env.h@730 PS3, Line 730: WriteStringToFileSyncEncrypted nit: maybe, name this WriteStringToFileEncryptedSync()? It seems the naming convention is to have Xxx() and XxxSync() counterpart, where the Sync prefix changes the behavior by calling Sync() after the operation. http://gerrit.cloudera.org:8080/#/c/18025/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/18025/3/src/kudu/util/env_posix.cc@919 PS3, Line 919: *size = st.st_size - (encrypted_ ? kEncryptionHeaderSize : 0); Consider adding DCHECK()/CHECK() on st.st_size being greater or equal to kEncryptionHeaderSize -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 24 Nov 2021 17:33:47 +0000 Gerrit-HasComments: Yes
