Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18059 )
Change subject: [scripts] add hard memory limit for mini-cluster processes ...................................................................... Patch Set 1: (2 comments) > I like this overall, however I have a few questions: > - Would it make sense to add a flag to override the 80% limit? > - Is there a lower bound for allocated memory for master/tserver? > What happens if the number of instances is so high that each of > them would be memory starved? In that case a warning should let the > user know. > > I might just be overcomplicating this though :) For the customization, there is always an option to override kudu-server flags. I think that covers the questions you asked. http://gerrit.cloudera.org:8080/#/c/18059/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/18059/1/src/kudu/scripts/start_kudu.sh@189 PS1, Line 189: echo "" > Missing an early return? Good catch! http://gerrit.cloudera.org:8080/#/c/18059/1/src/kudu/scripts/start_kudu.sh@221 PS1, Line 221: # but it doesn't hurt to set the limit > Shouldn't we give more memory to tservers than to masters because of this? Yup, sounds reasonable. The only question is about the exact quantity. One option to avoid thinking about exact numbers is simply not count for masters and not setting the hard limit for them. -- To view, visit http://gerrit.cloudera.org:8080/18059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4de6c96fb0227554edbd5e69b29840f84e408326 Gerrit-Change-Number: 18059 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 02 Dec 2021 20:02:00 +0000 Gerrit-HasComments: Yes
