Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18067 )
Change subject: [ranger] clarify error message from subprocess ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18067/2/src/kudu/subprocess/subprocess_proxy.h File src/kudu/subprocess/subprocess_proxy.h: http://gerrit.cloudera.org:8080/#/c/18067/2/src/kudu/subprocess/subprocess_proxy.h@95 PS2, Line 95: const char* subprocess_name_; nit: might be const char* const subprocess_name_ since the field isn't changing once an instance is created BTW, do we want to guard against usage like SubprocessProxy(..., some_ephemeral_string.c_str()) for the constructor? -- To view, visit http://gerrit.cloudera.org:8080/18067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a0fcd899439a822c6239494fedb0895adc046fd Gerrit-Change-Number: 18067 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 Dec 2021 15:52:58 +0000 Gerrit-HasComments: Yes
