Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18075 )
Change subject: [java] KUDU-2623 Expose table as public in WriteOp ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18075/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18075/2//COMMIT_MSG@7 PS2, Line 7: java > Why java? I might be missing something, but didn't find anything java-spec yeah, that was a brain fart, I meant client http://gerrit.cloudera.org:8080/#/c/18075/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18075/2/src/kudu/client/client-test.cc@3539 PS2, Line 3539: const char* > nit: could be Ack http://gerrit.cloudera.org:8080/#/c/18075/2/src/kudu/client/client-test.cc@3561 PS2, Line 3561: &overflow > Since 'overflow' isn't used in the code below, it's possible to pass 'nullp Ack http://gerrit.cloudera.org:8080/#/c/18075/2/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/18075/2/src/kudu/client/write_op.h@97 PS2, Line 97: const KuduTable* table() const { return table_.get(); } > It seems in 95dd95fde5d550f5ce8374f440e850d2cc722bf4 this has been moved in I haven't looked into it previously. This seemed the easiest/least intrusive way to expose this information so that it's available during error processing in the client. To be honest I'm not sure if I fully understand the implications of 95dd95fde5d550f5ce8374f440e850d2cc722bf4 I ran the whole test suite and didn't break anything, so please let me know if this breaks something in other ways. -- To view, visit http://gerrit.cloudera.org:8080/18075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbfff6e931304cce7826bc272811155f57a5c4e5 Gerrit-Change-Number: 18075 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Dec 2021 18:03:36 +0000 Gerrit-HasComments: Yes
