Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18082 )
Change subject: [rpc] style cleanup on transfer.{cc,h}
......................................................................
[rpc] style cleanup on transfer.{cc,h}
Since I was taking a look into the code of tranfer.{cc,h}, I also took
the liberty to update the code to be in-line with the style guide and
did other minor updates:
* added PREDICT_FALSE() into the hot path where appropriate
* removed declared but not defined ProcessInboundHeader() method
* corrected the return type of OutboundTransfer::TotalLength()
to be more future-proof
* other unsorted minor updates
Change-Id: Ib0efc5d815fd44b94737a999fee02a0413be62f1
Reviewed-on: http://gerrit.cloudera.org:8080/18082
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Andrew Wong <[email protected]>
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
3 files changed, 44 insertions(+), 48 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0efc5d815fd44b94737a999fee02a0413be62f1
Gerrit-Change-Number: 18082
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
