Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17633 )
Change subject: KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer ...................................................................... KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer It turns out that setting SASL security properties such as the minimum Security Strength Factor (SSF) once sasl_client_start() has already been called isn't working as expected anymore once patch [1] is applied for the cyrus-sasl-gssapi plugin. This patch addresses the issue, moving the call to sasl_setprop(..., SASL_SEC_PROPS, ...) prior to the corresponding call to sasl_client_start() in the client-side negotiation logic for C++ Kudu components. Prior to this patch, GSSAPI-involved scenarios of the negotiation-test and security-itest would fail when running against the GSSAPI plugin with patch [1] applied. With this patch, all scenarios in the negotiation-test and the security-itest pass. I didn't add any extra test scenarios since the already existing test coverage was enough to spot the issue, as it can be seen from above. [1] https://github.com/cyrusimap/cyrus-sasl/pull/603 Change-Id: Ia655356798c753d5a223933cc09a0731018e10af Reviewed-on: http://gerrit.cloudera.org:8080/17619 Reviewed-by: Grant Henke <granthe...@apache.org> Reviewed-by: Greg Solovyev <gsolov...@cloudera.com> Tested-by: Kudu Jenkins (cherry picked from commit fff48ea4e5eadd365a85a05a82f66b3eb76d0b0b) Reviewed-on: http://gerrit.cloudera.org:8080/17633 Tested-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/rpc/client_negotiation.cc 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.13.x Gerrit-MessageType: merged Gerrit-Change-Id: Ia655356798c753d5a223933cc09a0731018e10af Gerrit-Change-Number: 17633 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)
