Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18077 )
Change subject: [tools] Add the role field for 'kudu remote_replica list' ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/18077/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18077/6//COMMIT_MSG@7 PS6, Line 7: Add the role field for 'kudu remote_repl > How about: Done http://gerrit.cloudera.org:8080/#/c/18077/6//COMMIT_MSG@9 PS6, Line 9: Added the Raft role field into the output of the 'kudu remote_r > How about: Done http://gerrit.cloudera.org:8080/#/c/18077/6//COMMIT_MSG@10 PS6, Line 10: list' CLI tool. > How about moving this into a separate sentence for clarity: Done http://gerrit.cloudera.org:8080/#/c/18077/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18077/6/src/kudu/tools/kudu-tool-test.cc@3402 PS6, Line 3402: > Just curious: is it possible to see 'FOLLOWER' here at all even if kNumTser I think it's not possible to see 'FOLLOWER' since the RF is 1. Anyway, check all possible roles here is acceptable. -- To view, visit http://gerrit.cloudera.org:8080/18077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38d20d129b18f3a170ec5b0db5a2caf7c0d80ef Gerrit-Change-Number: 18077 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 23 Dec 2021 05:51:05 +0000 Gerrit-HasComments: Yes
