Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18025/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18025/3//COMMIT_MSG@30 PS3, Line 30: File sizes as returned by *File APIs are logical, so on disk they're 40 : bytes larger. The GetFileSize() can return both the logical and the : physical file size, but GetFileSizeOnDisk() actually uses block count : and must be physical. Some of the tests rely on this and make : assumptions based on the numbers reported here, these tests are not run : with encryption enabled. > You're right, it's better to use physical sizes everywhere and update the c I'm not sure I understand what's the problem if returning the actual size with the encryption header by GetFileSizeOnDisk() (and that does seem reasonable because of OnDisk suffix) and returning the logical size elsewhere when working with actual data in an encrypted file. -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 12 Jan 2022 18:00:51 +0000 Gerrit-HasComments: Yes
