Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18144 )

Change subject: [util] add scheduling priority metric for a server
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18144/1/src/kudu/util/thread.cc
File src/kudu/util/thread.cc:

http://gerrit.cloudera.org:8080/#/c/18144/1/src/kudu/util/thread.cc@114
PS1, Line 114: sched
> nit: maybe just call this scheduling_priority?
Sure.  I was just following the naming from corresponding man pages :)


http://gerrit.cloudera.org:8080/#/c/18144/1/src/kudu/util/thread.cc@118
PS1, Line 118:                           kudu::MetricLevel::kInfo);
> I'm curious whether we'd expect much if any variation in this. Is it rare f
Yes, I'd expect this to 0 almost always.  That's rather a debug-level metric to 
use when checking for anomalies and misconfigurations.



--
To view, visit http://gerrit.cloudera.org:8080/18144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I985511636a9099779a811eabe6785cf765ec04b7
Gerrit-Change-Number: 18144
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Jan 2022 06:10:25 +0000
Gerrit-HasComments: Yes

Reply via email to