Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18148 )
Change subject: [tools] Kudu table schema in Avro format revisited This is a follow-up patch to 55cab44 addressing the additional comments posted after the change has been cherry picked. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18148/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18148/1//COMMIT_MSG@8 PS1, Line 8: This is a follow-up patch to 55cab44 addressing the additional Leave a blank line between commit header and description http://gerrit.cloudera.org:8080/#/c/18148/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18148/1/src/kudu/tools/tool_action_table.cc@242 PS1, Line 242: JsonWriter& writer As per our C++ coding guidelines, we use pointer for output parameters. Same below. -- To view, visit http://gerrit.cloudera.org:8080/18148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0623812402a188e5b24bbde3db7ef0e3b4c618ec Gerrit-Change-Number: 18148 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 14 Jan 2022 00:16:02 +0000 Gerrit-HasComments: Yes
