Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18223 )
Change subject: KUDU-3352 fix handling sockaddr_in in Sockaddr ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18223/3/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/18223/3/src/kudu/util/net/sockaddr.cc@110 PS3, Line 110: HashCode() > Except function HashCode(), it also affects function BytewiseCompare(). Done http://gerrit.cloudera.org:8080/#/c/18223/3/src/kudu/util/net/sockaddr.cc@188 PS3, Line 188: sizeof(addr) > set length as offsetof(struct sockaddr_in, sin_zero)) Ah, good catch, thanks! -- To view, visit http://gerrit.cloudera.org:8080/18223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96fee11a4191a4f4240c460db22742880eebe7b5 Gerrit-Change-Number: 18223 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 11 Feb 2022 18:18:48 +0000 Gerrit-HasComments: Yes
