Hello Yingchun Lai, Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18236

to review the following change.


Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................

[common] fix a bug in Schema::Reset(cols, ...)

Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.

A new test scenario is added to cover the corresponding regressions in future.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Reviewed-on: http://gerrit.cloudera.org:8080/18213
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
(cherry picked from commit 426d2ecb04d0f76ac50fe0868f40398ba6848582)
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/18236/1
--
To view, visit http://gerrit.cloudera.org:8080/18236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18236
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>

Reply via email to