Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18283 )
Change subject: [security] avoid allocating string in SimpleAcl::UserAllowed() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18283/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18283/1//COMMIT_MSG@27 PS1, Line 27: std::string : > Interesting -- it makes sense, but for some reason it's still surprising su I guess two issues are in play here: (1) lock contention in libtcmalloc and (2) not providing enough template specializations (it seems map-util.h isn't very good at that) . The former is the major one and addressing it should make the latter a benign one. However, less allocations is always better than more, so I decided to do this tiny optimization instead of revving up my WIP patch of building latest libtcmalloc with cmake (sigh). -- To view, visit http://gerrit.cloudera.org:8080/18283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9ed6140cbcf0487ec76b9f769cdf24f9de7b52c Gerrit-Change-Number: 18283 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Mar 2022 02:23:03 +0000 Gerrit-HasComments: Yes
