Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18258 )
Change subject: [metrics] Add table level metrics column_count and schema_version on master ...................................................................... [metrics] Add table level metrics column_count and schema_version on master This patch adds some table level metrics on master. - column_count: The column count in the table's latest schema. Since too many column count will lead to bad performance and space amplification, we can add some monitor alerts based on this metric after this. - schema_version: The table's schema version. Too many or too frequently schema changes is also a metric worth to be monitored. Change-Id: Ia0671cfb0758d53e950a4e35a968dae15f82d18e Reviewed-on: http://gerrit.cloudera.org:8080/18258 Tested-by: Kudu Jenkins Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master-test.cc M src/kudu/master/table_metrics.cc M src/kudu/master/table_metrics.h 5 files changed, 90 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Abhishek Chennaka: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, but someone else must approve Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia0671cfb0758d53e950a4e35a968dae15f82d18e Gerrit-Change-Number: 18258 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
