KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17917 )
Change subject: KUDU-3326 [delete]: Add soft delete table supports ...................................................................... Patch Set 36: (6 comments) http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client-internal.h@131 PS35, Line 131: const std::string& table_id, > Assign Done http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.h@696 PS35, Line 696: /// @param [in] force_on_trashed_table : /// Whether to force to delete a trashed table. : /// @param [in] reserve_seconds : /// Reserve seconds after being deleted. > Is force_on_trashed_table and reserve_seconds are orthogonal? They are independent. http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.cc@513 PS35, Line 513: bool force_on_trashed_table, > Assign to the parameter above. Done http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.cc@523 PS35, Line 523: KuduClient::Da > Is there any compile complains if removing it? Done http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/client/client.cc@529 PS35, Line 529: KuduClient::Da > Same Done http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/17917/35/src/kudu/common/wire_protocol.cc@681 PS35, Line 681: Status ExtraConfigPBFromPBMap(const Map<string, string>& configs, TableExtraConfigPB* pb) { > Is this modification related to "trash table"? This modification has been removed -- To view, visit http://gerrit.cloudera.org:8080/17917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1dddfbca55a5c4bcac4028157325ad618ea665 Gerrit-Change-Number: 17917 Gerrit-PatchSet: 36 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 25 Mar 2022 03:47:12 +0000 Gerrit-HasComments: Yes
