Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix 
DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG@9
PS1, Line 9: 
DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
Better to paste what error you got, and what's the idea to fix it.


http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@216
PS1, Line 216:   void TestSizeLimit(int64_t row_count_limit = -1) {
How about void TestSizeLimit(int64_t row_count_limit = kRowCountLimit) ?



--
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sun, 24 Apr 2022 06:47:05 +0000
Gerrit-HasComments: Yes

Reply via email to