Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18447 )
Change subject: [threadpool] KUDU-3364 Add TimerThread for thread pool ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.h@149 PS1, Line 149: class TimerThread { > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.h@164 PS1, Line 164: }; > warning: parameter 'f' is passed by value and only copied once; consider mo Done http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.cc@109 PS1, Line 109: > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.cc@110 PS1, Line 110: TimerThread::TimerThread(std::string thread_pool_name) > warning: parameter 'thread_pool_name' is passed by value and only copied on Done http://gerrit.cloudera.org:8080/#/c/18447/1/src/kudu/util/threadpool.cc@249 PS1, Line 249: timepoint.AddDelta(MonoDelta::FromMilliseconds(delay_ms)); > warning: parameter 'f' is passed by value and only copied once; consider mo Done -- To view, visit http://gerrit.cloudera.org:8080/18447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If51fce48ae6a45a0bf3314f8a102ee373c5c442e Gerrit-Change-Number: 18447 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 25 Apr 2022 11:31:44 +0000 Gerrit-HasComments: Yes
