Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 )
Change subject: [client] fix toggling fault-tolerance for a scanner ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::ReadMode::READ_LATEST, sc.read_mode()); > Right, I might expect that kind of behavior in some ResetToDefault() call o Yep, that would be surprising and ResetToDefault() might be a good alternative. BTW, it's a bit surprising even now if trying something scanner.SetFaultTolerant(true); scanner.SetReadMode(READ_LATEST); It seems to be a bike-shedding avenue, but I guess the fault-tolerant is made some sort of fuzzy compound now, and the API doesn't provide a consistent API to work with it. Anyways, not preserving the READ_AT_SNAPSHOT mode makes some Java tests fail, so that's a hard indication we shouldn't touch the read mode while calling SetFaultTolerant(false). -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 02 May 2022 17:43:42 +0000 Gerrit-HasComments: Yes
