Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18448 )
Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local' ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18448/7/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18448/7/src/kudu/tools/tool_action_local_replica.cc@525 PS7, Line 525: if (ContainsKey(failed_tablet_ids, tablet_id)) continue; Now tablet_ids_to_copy doesn't contain not-found tables, do we still need this? -- To view, visit http://gerrit.cloudera.org:8080/18448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4de49e948cc1a686db5e1bf424470ca9e800ee36 Gerrit-Change-Number: 18448 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 05 May 2022 04:52:01 +0000 Gerrit-HasComments: Yes
