Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18447 )
Change subject: [threadpool] KUDU-3364 Add TimerThread for thread pool ...................................................................... Patch Set 13: (6 comments) http://gerrit.cloudera.org:8080/#/c/18447/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18447/11//COMMIT_MSG@9 PS11, Line 9: Add TimerThread to ThreadPool to support > nit: to support executing tasks asynchronously or with a delay Done http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.h@571 PS11, Line 571: // TimerThread is used for some scenarios, such as > Nit: Scenarios Done http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.h@572 PS11, Line 572: // make a task delay execution. > Nit: scheduled Done http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.h@573 PS11, Line 573: TimerThread* timer_; > Comment is rather unclear, could you please clarify it a bit? Done http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.h@602 PS11, Line 602: Status Schedule(std::function<void()> f, int64_t delay_ms) WARN_UNUSED_RESULT; > Does this run the task submitted and delay afterwards or introduces a delay delay---> execute task. http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18447/11/src/kudu/util/threadpool.cc@247 PS11, Line 247: return Status::NotSupported(Substitute("unsupported mode: CONCURRENT")); > nit: Unsupported mode: CONCURRENT Done -- To view, visit http://gerrit.cloudera.org:8080/18447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If51fce48ae6a45a0bf3314f8a102ee373c5c442e Gerrit-Change-Number: 18447 Gerrit-PatchSet: 13 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 07 May 2022 02:57:20 +0000 Gerrit-HasComments: Yes
