Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java: http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@410 PS6, Line 410: if (col.getType() == Type.STRING || col.getType() == Type.BINARY || > nit: can you replace this with the new isFixedSize() function as well? Whoops, missed this one. Good catch! Done. -- To view, visit http://gerrit.cloudera.org:8080/18494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380 Gerrit-Change-Number: 18494 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 23:48:43 +0000 Gerrit-HasComments: Yes
