Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18447 )
Change subject: [threadpool] KUDU-3364 Add TimerThread for thread pool ...................................................................... Patch Set 19: (5 comments) http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.h@172 PS19, Line 172: bool empty() { nit: delare it as a const function. http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.h@280 PS19, Line 280: // Used by tests to avoid tsan test case down. If it is only used in tests, better to deaclare it as a private function. http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.cc@127 PS19, Line 127: kudu:: nit: can be omit. http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.cc@128 PS19, Line 128: [scheduler] nit: 'scheduler' is OK, to keep the same style to other Threads. http://gerrit.cloudera.org:8080/#/c/18447/19/src/kudu/util/threadpool.cc@142 PS19, Line 142: std::vector<SchedulerTask> pending_tasks; nit: `using std::vector;` in the header of the file and use vector directly here. Similar to std::string. -- To view, visit http://gerrit.cloudera.org:8080/18447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If51fce48ae6a45a0bf3314f8a102ee373c5c442e Gerrit-Change-Number: 18447 Gerrit-PatchSet: 19 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 16 May 2022 12:07:43 +0000 Gerrit-HasComments: Yes
