Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18532 )
Change subject: KUDU-2671 fix the check for hash dimensions uniformity ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18532/1/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/18532/1/src/kudu/integration-tests/table_locations-itest.cc@192 PS1, Line 192: keeping nit: keep http://gerrit.cloudera.org:8080/#/c/18532/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18532/1/src/kudu/master/catalog_manager.cc@1952 PS1, Line 1952: const auto hash_dimensions_num = partition_schema.hash_schema().size(); I'm not sure I understand this bug. Could you perhaps give an example where the previous code would be faulty? As a more general note, we should check for this in the alter table code path as well so additional ranges will have the same number of hash dimensions as the existing ranges. -- To view, visit http://gerrit.cloudera.org:8080/18532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c1282973deba57269f6e962be77e27baa39b187 Gerrit-Change-Number: 18532 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 07:28:36 +0000 Gerrit-HasComments: Yes
