KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17917 )
Change subject: KUDU-3326 [delete]: Add soft delete table supports ...................................................................... Patch Set 59: (2 comments) http://gerrit.cloudera.org:8080/#/c/17917/58/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17917/58/src/kudu/client/client.h@797 PS58, Line 797: non-trash tables whose na > nit: non-trash tables whose Done http://gerrit.cloudera.org:8080/#/c/17917/58/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17917/58/src/kudu/master/catalog_manager.cc@2400 PS58, Line 2400: r::SoftDeleteTable(const Del > Do we want to mark the Trash state of the tables in HMS or delete the table I think the former is better. The trash state does not mean that the table has been completely deleted, but an intermediate state. So just mark it. As for this todo, it doesn't affect normal use, so I'm going to submit it after this commit. -- To view, visit http://gerrit.cloudera.org:8080/17917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1dddfbca55a5c4bcac4028157325ad618ea665 Gerrit-Change-Number: 17917 Gerrit-PatchSet: 59 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 01:48:42 +0000 Gerrit-HasComments: Yes
