Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18453 )
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics ...................................................................... Patch Set 5: (3 comments) LGTM. Just a few nits. http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG@7 PS5, Line 7: update lastPropagatedTimestamp and resourceMetrics nit: What about 'update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback'? http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java: http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@227 PS5, Line 227: // bytes_read is 0. : // String metricName = "bytes_read"; nit: Is this comments needed? http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@229 PS5, Line 229: metricName nit: What about rename to 'kMetricName'? -- To view, visit http://gerrit.cloudera.org:8080/18453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331 Gerrit-Change-Number: 18453 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 15:24:04 +0000 Gerrit-HasComments: Yes
