Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18192 )
Change subject: KUDU-3368 Encrypt file keys with server keys ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18192/6/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18192/6/src/kudu/fs/fs_manager.cc@677 PS6, Line 677: uint8_t key_bytes[32]; : int num_bytes = FLAGS_encryption_key_length / 8; : DCHECK(num_bytes <= sizeof(key_bytes)); : OPENSSL_RET_NOT_OK(RAND_bytes(key_bytes, num_bytes), > Right, but that code is in different place and hypothetically it could cha Good point, added a DCHECK -- To view, visit http://gerrit.cloudera.org:8080/18192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1884f62fde3bb110291b1d01c5e68942c6071318 Gerrit-Change-Number: 18192 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 26 May 2022 13:39:44 +0000 Gerrit-HasComments: Yes
