Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18582 )
Change subject: KUDU-2671 refactor PartitionSchema::CreatePartitions() ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/18582/8/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18582/8/src/kudu/common/partition.cc@626 PS8, Line 626: Status PartitionSchema::CreatePartitions(const Schema& schema, : vector<Partition>* partitions) const { : return CreatePartitions(ranges_with_hash_schemas_, schema, partitions); : } > Why is this method necessary? Why can't we just directly call the CreatePar Yep, that's an option. I entertained that one as well, but I also hoped it would be possible to make such method static. But that's not the case, and I also plan to make PartionSchema::ranges_with_hash_schemas() private eventually (right now it's used only in tests, as I can see). With that, I decided to add this method. I guess we have an opportunity to refactor PartitionSchema class further: that class contains too much logic of different sorts and has too many responsibilities. http://gerrit.cloudera.org:8080/#/c/18582/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18582/8/src/kudu/master/catalog_manager.cc@2635 PS8, Line 2635: bouds > nit:bounds Thanks for pointing out at this! This nit is addressed in a follow-up patch: https://gerrit.cloudera.org/#/c/18615 To reduce the churn of code reviews, I'd keep it as is in this patch, knowing that the follow-up patch fixes the spelling. -- To view, visit http://gerrit.cloudera.org:8080/18582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bac1f8ee349577e2f912530a28776415ed0a5b0 Gerrit-Change-Number: 18582 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jun 2022 17:13:19 +0000 Gerrit-HasComments: Yes
