Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18638 )
Change subject: [common] switch to std::optional ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/column_predicate-test.cc@25 PS3, Line 25: #include <optional> do we use optional in this file? http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/generic_iterators.cc@32 PS3, Line 32: #include <type_traits> don't we need to include <optional> http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: http://gerrit.cloudera.org:8080/#/c/18638/3/src/kudu/common/scan_spec-test.cc@22 PS3, Line 22: #include <optional> do we need optional here? -- To view, visit http://gerrit.cloudera.org:8080/18638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae320c3ed2487b896539fcbad4425c8480a4b349 Gerrit-Change-Number: 18638 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 11:33:01 +0000 Gerrit-HasComments: Yes
